Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Edward O'Callaghan.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75877?usp=email )
Change subject: flashchips: change chip lock status funcs for Winbond chips ......................................................................
Patch Set 2:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/75877/comment/5aab8217_d3ddec7e : PS2, Line 17877: SPI_PRETTYPRINT_STATUS_REGISTER_AMIC_A25L032
I wanted to ask, how did you pick the printlock func? (I want to understand for myself). […]
I agree, `AMIC_A25L032` doesn't seem like the right printlock function for a winbond chip.
It probably won't break anything since the AMIC function just reads status register 1, which winbond chips also have.
If `AMIC_A25L032` prints the bits correctly then it could be renamed to a generic name and used here.