Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Edward O'Callaghan.
View Change
1 comment:
File flashchips.c:
Patch Set #2, Line 17877: SPI_PRETTYPRINT_STATUS_REGISTER_AMIC_A25L032
I wanted to ask, how did you pick the printlock func? (I want to understand for myself). […]
I agree, `AMIC_A25L032` doesn't seem like the right printlock function for a winbond chip.
It probably won't break anything since the AMIC function just reads status register 1, which winbond chips also have.
If `AMIC_A25L032` prints the bits correctly then it could be renamed to a generic name and used here.
To view, visit change 75877. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5066863b514825aee0dffe496492514ac99b6e49
Gerrit-Change-Number: 75877
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Goncharov <chat@joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Alexander Goncharov <chat@joursoir.net>
Gerrit-Comment-Date: Fri, 14 Jul 2023 02:44:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment