Attention is currently required from: Nico Huber, Paul Menzel, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51978 ) Change subject: test_build.sh: use sh from env ...................................................................... Patch Set 1: (1 comment) Patchset: PS1:
I think there are pros and cons for this pattern. Which ones? I'm curious.
If I were an English teacher, I'd ask you to write a for-and-against essay. đ But since I'm not, a brief explanation is more than enough đ -- To view, visit https://review.coreboot.org/c/flashrom/+/51978 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3897b8d980425ecbb89b238d4a766f628cf9d3e6 Gerrit-Change-Number: 51978 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src@posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Nico Huber <nico.h@gmx.de> Gerrit-Attention: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Attention: Thomas Heijligen <src@posteo.de> Gerrit-Comment-Date: Wed, 31 Mar 2021 12:44:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: comment