Attention is currently required from: Nico Huber, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54712 )
Change subject: sb600spi.c: Move sb600_spibar into spi data instead of being global ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
File sb600spi.c:
https://review.coreboot.org/c/flashrom/+/54712/comment/ee8e9bce_77d8eaad PS1, Line 59: sb600_spibar The `sb600_` prefix isn't needed. Oh, I see CB:54714 takes care of it.
https://review.coreboot.org/c/flashrom/+/54712/comment/f7dd2a91_3497be08 PS1, Line 610: free(data);
not free'ed as its physical memory but technically it should be unmapped yes although I think everyo […]
`sb600_spibar` is not a pointer to dynamically-allocated memory, so it must not be free()'d. However, one should use physunmap() or some other function from physmap.c to properly clean up.
I'd do this in a separate commit.