Attention is currently required from: Nico Huber, Anastasia Klimchuk.

Patch set 1:Code-Review +2

View Change

2 comments:

• File sb600spi.c:

  • Patch Set #1, Line 59: sb600_spibar

    The `sb600_` prefix isn't needed. Oh, I see CB:54714 takes care of it.

  • Patch Set #1, Line 610: free(data);

    not free'ed as its physical memory but technically it should be unmapped yes although I think everyo […]

    `sb600_spibar` is not a pointer to dynamically-allocated memory, so it must not be free()'d. However, one should use physunmap() or some other function from physmap.c to properly clean up.

    I'd do this in a separate commit.

To view, visit change 54712. To unsubscribe, or for help writing mail filters, visit settings.