[flashrom-gerrit] Change in flashrom[master]: Add support for National Instruments USB-845x devices

[Márton Miklós (Code Review)]

Márton Miklós has posted comments on this change. ( https://review.coreboot.org/25683 )

Change subject: Add support for National Instruments USB-845x devices
......................................................................

Patch Set 10:

(1 comment)

https://review.coreboot.org/#/c/25683/10/ni845x_spi.c
File ni845x_spi.c:

https://review.coreboot.org/#/c/25683/10/ni845x_spi.c@123
PS10, Line 123: %ld
> This is not the standard-compliant format specifier for int32. You include inttypes. […]

int32 is coming from the NI's header where it is defined as a  long:
typedef long            int32;

As far as I know it translates to long int which (according to this matrix: http://www.cplusplus.com/reference/cstdio/printf/) should be okay for the %ld, but let me know if I missed something.

I have used the NI's types only where I interact with their API just to be sure.