View Change
1 comment:
File ni845x_spi.c:
Patch Set #10, Line 123: %ld
This is not the standard-compliant format specifier for int32. You include inttypes. […]
int32 is coming from the NI's header where it is defined as a long:
typedef long int32;
As far as I know it translates to long int which (according to this matrix: http://www.cplusplus.com/reference/cstdio/printf/) should be okay for the %ld, but let me know if I missed something.
I have used the NI's types only where I interact with their API just to be sure.
To view, visit change 25683. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549
Gerrit-Change-Number: 25683
Gerrit-PatchSet: 10
Gerrit-Owner: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Miklós Márton <martonmiklosqdev@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Elyes HAOUAS <ehaouas@noos.fr>
Gerrit-CC: Márton Miklós <martonmiklosqdev@gmail.com>
Gerrit-CC: Stefan Tauner <stefan.tauner@gmx.at>
Gerrit-Comment-Date: Mon, 27 Aug 2018 16:34:35 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No