Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62764 )
Change subject: ich_descriptors.c: Ensure unsigned types >=0 on to prevent underflow ......................................................................
Patch Set 18:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62764/comment/95fb59b3_6fee4647 PS18, Line 11: this value for left shifting could be even more dangerous.
Just for future commits. If the nature of the patch changes during […]
I was looking at commit message yesterday and thought about it. It still seemed okay to me for the latest patchset. Sorry if that was a mistake!
I was thinking, the left shifting is still there, and generic statement about undefined behaviour still seems relevant?
One thing has changed for me during review: in the beginning I thought there might be a possible error. But then I realised there was no error, but the code looked like there could be.