1 comment:
Commit Message:
Patch Set #18, Line 11: this value for left shifting could be even more dangerous.
Just for future commits. If the nature of the patch changes during […]
I was looking at commit message yesterday and thought about it. It still seemed okay to me for the latest patchset. Sorry if that was a mistake!
I was thinking, the left shifting is still there, and generic statement about undefined behaviour still seems relevant?
One thing has changed for me during review: in the beginning I thought there might be a possible error. But then I realised there was no error, but the code looked like there could be.
To view, visit change 62764. To unsubscribe, or for help writing mail filters, visit settings.