Attention is currently required from: Nico Huber, Martin L Roth, Edward O'Callaghan.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62745 )
Change subject: test_build.sh: Allow WARNERROR to be overridden
......................................................................
Patch Set 1:
(1 comment)
File test_build.sh:
https://review.coreboot.org/c/flashrom/+/62745/comment/fad54005_23ca7264
PS1, Line 4: ${WARNERROR-yes}
Maybe just add a colon. so that it is very clear? I mean
${WARNERROR:-yes}
Official instruction in Makefile says "If your compiler spits out excessive warnings, run make WARNERROR=no". I spent some time thinking what is going to happen if WARNERROR is empty, but then I thought, better make it clear instead of thinking.
Otherwise all good.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62745
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iea931e57f2a6992762566dc3dbaae8bb8df5b226
Gerrit-Change-Number: 62745
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth
martinroth@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin L Roth
martinroth@google.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Tue, 03 May 2022 00:46:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment