Attention is currently required from: Nico Huber, Martin L Roth, Edward O'Callaghan.

View Change

1 comment:

• File test_build.sh:

  • Patch Set #1, Line 4: ${WARNERROR-yes}

    Maybe just add a colon. so that it is very clear? I mean
     ${WARNERROR:-yes}

    Official instruction in Makefile says "If your compiler spits out excessive warnings, run make WARNERROR=no". I spent some time thinking what is going to happen if WARNERROR is empty, but then I thought, better make it clear instead of thinking.

    Otherwise all good.

To view, visit change 62745. To unsubscribe, or for help writing mail filters, visit settings.