Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons, Anastasia Klimchuk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63488 )
Change subject: ich_descriptors_tool: Fix -Wsign-compare warnings
......................................................................
Patch Set 1:
(1 comment)
File util/ich_descriptors_tool/ich_descriptors_tool.c:
https://review.coreboot.org/c/flashrom/+/63488/comment/7aa24f55_04fcca4d
PS1, Line 87: uint32_t
I would prefer doing variable declarations at the beginning of the method, so that these are not scattered and one can find them easily.
I'd capture the value in an immutable variable, e.g.
const ssize_t ret = ...
This way one doesn't have to keep track of potentially mutable state.
(and as C doesn't allow assignments to immutable variables, we can't
argue where to declare it)
--
To view, visit
https://review.coreboot.org/c/flashrom/+/63488
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1f9325e9cf89f57f18d63cc3906a0958b47286d7
Gerrit-Change-Number: 63488
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Peter Marheine
pmarheine@chromium.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Fri, 08 Apr 2022 16:28:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment