Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons, Anastasia Klimchuk.

View Change

1 comment:

• File util/ich_descriptors_tool/ich_descriptors_tool.c:

  • Patch Set #1, Line 87: uint32_t

    I would prefer doing variable declarations at the beginning of the method, so that these are not scattered and one can find them easily.

    I'd capture the value in an immutable variable, e.g.

      const ssize_t ret = ...

    This way one doesn't have to keep track of potentially mutable state.
    (and as C doesn't allow assignments to immutable variables, we can't
    argue where to declare it)

To view, visit change 63488. To unsubscribe, or for help writing mail filters, visit settings.