22 Dec
2022
22 Dec
'22
6:16 p.m.
Attention is currently required from: Thomas Heijligen, Name of user not set #1004601.
Peter Stuge has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70571 )
Change subject: serial: Add Darwin/macOS support for custom and >230400 baudrates ......................................................................
Patch Set 7:
(2 comments)
Patchset:
PS7: Thanks, glad to drop the change in between!
Now I just don't understand why this change still has a Merge Conflict.
File serial.c:
https://review.coreboot.org/c/flashrom/+/70571/comment/3710e293_59145c48 PS4, Line 78: #if !IS_DARWIN
I would prefer the variant in use_custom_baud(). […]
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/70571
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3e6b88d2b4c2a130b16456752681fd9f807bf6f0
Gerrit-Change-Number: 70571
Gerrit-PatchSet: 7
Gerrit-Owner: Peter Stuge peter@stuge.se
Gerrit-Reviewer: Name of user not set #1004601
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Name of user not set #1004601
Gerrit-Comment-Date: Thu, 22 Dec 2022 17:16:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peter Stuge peter@stuge.se
Comment-In-Reply-To: Thomas Heijligen src@posteo.de
Gerrit-MessageType: comment