Attention is currently required from: Matti Finder, Peter Marheine.
Anastasia Klimchuk has posted comments on this change by Matti Finder. ( https://review.coreboot.org/c/flashrom/+/84840?usp=email )
Change subject: cli_classic: Add rpmc command support ......................................................................
Patch Set 4:
(1 comment)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/84840/comment/2ae7e1e9_564bccff?usp... : PS4, Line 1323: if (options.rpmc_read_data) : ret = rpmc_read_data(fill_flash);
Making it API-friendly sounds good, but I would hold off on adding this support to the public API si […]
I think having code in a separate file rpmc.c is better, you don't need to move it. Keep rpmc.c and include/rpmc.h as separate files.
When it comes to libflashrom, you will call functions from rpmc.c in the libflashrom.c. As existing example, write-protect functionality designed like this. You can look at the code, in libflashrom.c it has prefix `flashrom_wp`