Attention is currently required from: Matti Finder, Peter Marheine.

View Change

1 comment:

• File cli_classic.c:

  • Patch Set #4, Line 1323:

    	if (options.rpmc_read_data)
    		ret = rpmc_read_data(fill_flash);
    

    Making it API-friendly sounds good, but I would hold off on adding this support to the public API si […]

    I think having code in a separate file rpmc.c is better, you don't need to move it. Keep rpmc.c and include/rpmc.h as separate files.

    When it comes to libflashrom, you will call functions from rpmc.c in the libflashrom.c.
    As existing example, write-protect functionality designed like this. You can look at the code, in libflashrom.c it has prefix `flashrom_wp`

To view, visit change 84840. To unsubscribe, or for help writing mail filters, visit settings.