Attention is currently required from: Alexander Goncharov.
Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72154 )
Change subject: ni845x_spi: pass global state through func params ......................................................................
Patch Set 5:
(1 comment)
File ni845x_spi.c:
https://review.coreboot.org/c/flashrom/+/72154/comment/818fa7d6_672dea96 PS2, Line 290: if (set_io_voltage_mV)
Miklós, how about dropping this condition? Maybe not in this patch, but in the one of the next. […]
I am fine wiht the dropping, I think my intention when adding was something like this: what if at some point I will not care about the voltage set actually and then I could just pass NULL to set_io_voltage_mV.