Attention is currently required from: Alexander Goncharov.
View Change
1 comment:
File ni845x_spi.c:
Patch Set #2, Line 290: if (set_io_voltage_mV)
Miklós, how about dropping this condition? Maybe not in this patch, but in the one of the next. […]
I am fine wiht the dropping, I think my intention when adding was something like this: what if at some point I will not care about the voltage set actually and then I could just pass NULL to set_io_voltage_mV.
To view, visit change 72154. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5daeb0839a4cc18b82d38cc06eeba88a619bec61
Gerrit-Change-Number: 72154
Gerrit-PatchSet: 5
Gerrit-Owner: Alexander Goncharov <chat@joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Miklós Márton <martonmiklosqdev@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Alexander Goncharov <chat@joursoir.net>
Gerrit-Comment-Date: Fri, 14 Apr 2023 20:29:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alexander Goncharov <chat@joursoir.net>
Gerrit-MessageType: comment