Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk, Peter Marheine. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64030 )
Change subject: meson: link flashrom binary against static libflashrom ......................................................................
Patch Set 2:
(3 comments)
File meson.build:
https://review.coreboot.org/c/flashrom/+/64030/comment/ecdc3dff_a8bcd575 PS1, Line 431: lib
must stay 'flashrom', now it's liblibflashrom
Done
https://review.coreboot.org/c/flashrom/+/64030/comment/3627e763_fef8e0a5 PS1, Line 477: # we can't just link_with libflashrom as we require all the internal symbols...
Obsolete comment?
Done
https://review.coreboot.org/c/flashrom/+/64030/comment/ae74cc05_0af1e279 PS1, Line 489: link_with : libflashrom.get_static_lib(), # flashrom needs internal symbols of libflashrom
This will fail if default_library is set to anything but 'both'. […]
For now both_libraries will be fine. We might be reworking this when adding support for libpayload.