Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk, Peter Marheine.

View Change

3 comments:

• File meson.build:

  • Patch Set #1, Line 431: lib

    must stay 'flashrom', now it's liblibflashrom

    Done

  • Patch Set #1, Line 477: # we can't just link_with libflashrom as we require all the internal symbols...

    Obsolete comment?

    Done

  • Patch Set #1, Line 489: link_with : libflashrom.get_static_lib(), # flashrom needs internal symbols of libflashrom

    This will fail if default_library is set to anything but 'both'. […]

    For now both_libraries will be fine. We might be reworking this when adding support for libpayload.

To view, visit change 64030. To unsubscribe, or for help writing mail filters, visit settings.