Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30995 ) Change subject: ichspi: Add Apollo Lake support ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/30995/1/ichspi.c File ichspi.c: https://review.coreboot.org/#/c/30995/1/ichspi.c@1758 PS1, Line 1758: num_freg = 16 Is this BIOS_FREGx from APL Datasheet 3 (334819-001)? There are only BIOS_FREG0 ... BIOS_FREG11 -- To view, visit https://review.coreboot.org/c/flashrom/+/30995 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1c464b5b3d151e6d28d5db96495fe874a0a45718 Gerrit-Change-Number: 30995 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Thomas Heijligen <src@posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Tue, 22 Jan 2019 13:40:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment