Attention is currently required from: Sam McNally, Edward O'Callaghan. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55403 )
Change subject: lspcon: restart MPU on programmer shutdown ......................................................................
Patch Set 2:
(1 comment)
File lspcon_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/55403/comment/1aa4fa32_aba9e01f PS1, Line 321: static int lspcon_i2c_spi_reset_mpu_stop(int fd) : { : int ret = 0; : ret |= lspcon_i2c_spi_write_register(fd, MPU, 0xc0); // cmd mode : ret |= lspcon_i2c_spi_write_register(fd, MPU, 0x40); // stop mcu : : return ret; : } : : static int lspcon_i2c_spi_start_mpu(int fd) : { : int ret; : // Assert reset : if ((ret = lspcon_i2c_spi_write_register(fd, MPU, 0xc0)) != 0) : return ret; : // Release reset and start MPU : return lspcon_i2c_spi_write_register(fd, MPU, 0); : } :
Hey Peter, could just perhaps just combine these two functions as `lspcon_i2c_spi_mcu_state_toggle` […]
Done