Attention is currently required from: Sam McNally, Edward O'Callaghan.
View Change
1 comment:
File lspcon_i2c_spi.c:
Patch Set #1, Line 321:
static int lspcon_i2c_spi_reset_mpu_stop(int fd)
{
int ret = 0;
ret |= lspcon_i2c_spi_write_register(fd, MPU, 0xc0); // cmd mode
ret |= lspcon_i2c_spi_write_register(fd, MPU, 0x40); // stop mcu
return ret;
}
static int lspcon_i2c_spi_start_mpu(int fd)
{
int ret;
// Assert reset
if ((ret = lspcon_i2c_spi_write_register(fd, MPU, 0xc0)) != 0)
return ret;
// Release reset and start MPU
return lspcon_i2c_spi_write_register(fd, MPU, 0);
}
Hey Peter, could just perhaps just combine these two functions as `lspcon_i2c_spi_mcu_state_toggle` […]
Done
To view, visit change 55403. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I66cd68f8f6905a2bfaf5b085bf08dcb218f42855
Gerrit-Change-Number: 55403
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Sam McNally <sammc@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Sam McNally <sammc@google.com>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Comment-Date: Tue, 15 Jun 2021 00:42:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-MessageType: comment