Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43527 )
Change subject: raiden_debug_spi: add param for a custom reset setup ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/flashrom/+/43527/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/43527/3//COMMIT_MSG@9 PS3, Line 9: Cr50 `The Chromium TPM Cr50 asserts...`
Others may not know what a Cr50 is outside the Google ecosystem.
https://review.coreboot.org/c/flashrom/+/43527/3//COMMIT_MSG@10 PS3, Line 10: some boards. `some Chromium boards` also would be nice to elaborate here a little more, breaks how?
One possible suggestion for someone without context:
``` The Chromium TPM Cr50 asserts EC_RST_L while flashing the AP however this doesn't work on some Chromium boards depending on EC configuration. This adds a custom_rst spi master parameter to tell the Cr50 not to assert any system reset signals during a AP flashing. ```
https://review.coreboot.org/c/flashrom/+/43527/3/raiden_debug_spi.c File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/43527/3/raiden_debug_spi.c@458 PS3, Line 458: tract_programmer_param("custom_rst"); Any new parameters should be documented in the man page as well.