View Change

3 comments:

• Commit Message:

  • Patch Set #3, Line 9: Cr50

    `The Chromium TPM Cr50 asserts...`

    Others may not know what a Cr50 is outside the Google ecosystem.

  • Patch Set #3, Line 10: some boards.

    `some Chromium boards` also would be nice to elaborate here a little more, breaks how?

    One possible suggestion for someone without context:

    ```
    The Chromium TPM Cr50 asserts EC_RST_L while flashing the AP however this doesn't work on some Chromium boards depending on EC configuration. This adds a custom_rst spi master parameter to tell the Cr50 not to assert any system reset signals during a AP flashing.
    ```

• File raiden_debug_spi.c:

  • Patch Set #3, Line 458: tract_programmer_param("custom_rst");

    Any new parameters should be documented in the man page as well.

To view, visit change 43527. To unsubscribe, or for help writing mail filters, visit settings.