[flashrom-gerrit] [M] Change in flashrom[master]: Added support for Macronix MX25V1635F Tested working on a new chip wi...

[Gabriel Tremblay (Code Review)]

Gabriel Tremblay has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/70211 )

Change subject: Added support for Macronix MX25V1635F Tested working on a new chip with raspberrypi spi.
......................................................................

Added support for Macronix MX25V1635F
Tested working on a new chip with raspberrypi spi.

Change-Id: I86088b663d6eb26895956c4c8b4ca5a79c619535
---
M flashchips.c
M include/flashchips.h
2 files changed, 51 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/70211/1

diff --git a/flashchips.c b/flashchips.c
index 6f65389..7a12dec 100644
--- a/flashchips.c
+++ b/flashchips.c
@@ -8708,7 +8708,8 @@
    		}
    	},
    	.printlock	= SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, /* bit6 is quad enable */
-		.unlock		= SPI_DISABLE_BLOCKPROTECT_BP3_SRWD,
+		/*.unlock		= SPI_DISABLE_BLOCKPROTECT_BP3_SRWD,*/
+                .unlock		= SPI_DISABLE_BLOCKPROTECT,
    	.write		= SPI_CHIP_WRITE256,
    	.read		= SPI_CHIP_READ, /* Fast read (0x0B) and multi I/O supported */
    	.voltage	= {2700, 3600},
@@ -9576,6 +9577,44 @@

{
    	.vendor		= "Macronix",
+		.name		= "MX25V1635F",
+		.bustype	= BUS_SPI,
+		.manufacture_id	= MACRONIX_ID,
+		.model_id	= MACRONIX_MX25V1635F,
+		.total_size	= 16384,
+		.page_size	= 256,
+		/* MX25V1635F supports SFDP */
+		.feature_bits	= FEATURE_WRSR_WREN | FEATURE_OTP,
+		.probe		= PROBE_SPI_RDID,
+		.probe_timing	= TIMING_ZERO,
+		.block_erasers	=
+		{
+			{
+				.eraseblocks = { {4 * 1024, 4096} },
+				.block_erase = SPI_BLOCK_ERASE_20,
+			}, {
+				.eraseblocks = { {32 * 1024, 512} },
+				.block_erase = SPI_BLOCK_ERASE_52,
+			}, {
+				.eraseblocks = { {64 * 1024, 256} },
+				.block_erase = SPI_BLOCK_ERASE_D8,
+			}, {
+				.eraseblocks = { {16 * 1024 * 1024, 1} },
+				.block_erase = SPI_BLOCK_ERASE_60,
+			}, {
+				.eraseblocks = { {16 * 1024 * 1024, 1} },
+				.block_erase = SPI_BLOCK_ERASE_C7,
+			},
+		},
+		.printlock	= SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, 
+		.unlock		= SPI_DISABLE_BLOCKPROTECT_BP3_SRWD,
+		.write		= SPI_CHIP_WRITE256,
+		.read		= SPI_CHIP_READ, /* Fast read (0x0B) supported, MX25V1635F supports dual I/O */
+		.voltage	= {2700, 3600}, /* 2.35-3.6V for MX25V1635F */
+	},
+
+	{
+		.vendor		= "Macronix",
    	.name		= "MX25U12835F",
    	.bustype	= BUS_SPI,
    	.manufacture_id	= MACRONIX_ID,
diff --git a/include/flashchips.h b/include/flashchips.h
index 5df42dc..42d9b07 100644
--- a/include/flashchips.h
+++ b/include/flashchips.h
@@ -524,7 +524,7 @@

#define MACRONIX_MX25R3235F	0x2816
 #define MACRONIX_MX25R6435F	0x2817
-
+#define MACRONIX_MX25V1635F	0x2315
 #define MACRONIX_MX29F001B	0x19
 #define MACRONIX_MX29F001T	0x18
 #define MACRONIX_MX29F002B	0x34	/* Same as MX29F002NB; N has reset pin n/c. */