Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39687 )
Change subject: lspcon_i2c_spi.c: Add SPI-master support for PS17{5,6} ......................................................................
Patch Set 4: Code-Review+2
(5 comments)
https://review.coreboot.org/c/flashrom/+/39687/4/lspcon_i2c_spi.c File lspcon_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/39687/4/lspcon_i2c_spi.c@314 PS4, Line 314: 100000000 `(unsigned)1e8` is more readable.
https://review.coreboot.org/c/flashrom/+/39687/4/lspcon_i2c_spi.c@314 PS4, Line 314: wait_100_ms wait_100ms
https://review.coreboot.org/c/flashrom/+/39687/4/lspcon_i2c_spi.c@364 PS4, Line 364: uint8_t write_buffer[len + 1]; I find these VLA usages and clever ptr arithmetic to idx after the few elem a little unsettling. I guess i'll let it fly here.
https://review.coreboot.org/c/flashrom/+/39687/4/lspcon_i2c_spi.c@415 PS4, Line 415: stop stopped
https://review.coreboot.org/c/flashrom/+/39687/4/meson_options.txt File meson_options.txt:
https://review.coreboot.org/c/flashrom/+/39687/4/meson_options.txt@38 PS4, Line 38: true Do we perhaps want to default to false as the i2c helper only currently supports Linux and thus would break builds on the BSD's with missing symbols at link-time.
Also the desc needs changing: 'Parade lspcon USB-C to HDMI protocol translator'