Patch set 4:Code-Review +2

View Change

5 comments:

• File lspcon_i2c_spi.c:

  • Patch Set #4, Line 314: 100000000

    `(unsigned)1e8` is more readable.

  • Patch Set #4, Line 314: wait_100_ms

    wait_100ms

  • Patch Set #4, Line 364: uint8_t write_buffer[len + 1];

    I find these VLA usages and clever ptr arithmetic to idx after the few elem a little unsettling. I guess i'll let it fly here.

  • Patch Set #4, Line 415: stop

    stopped

• File meson_options.txt:

  • Patch Set #4, Line 38: true

    Do we perhaps want to default to false as the i2c helper only currently supports Linux and thus would break builds on the BSD's with missing symbols at link-time.

    Also the desc needs changing: 'Parade lspcon USB-C to HDMI protocol translator'

To view, visit change 39687. To unsubscribe, or for help writing mail filters, visit settings.