Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/45944 )
Change subject: realtek_mst_i2c_spi.c: Fixup get_params() err ctrl flow ......................................................................
Patch Set 3:
(1 comment)
Patch Set 3:
Why on Earth was this fast-tracked? I was sleeping when this patch was created and submitted...
https://www.flashrom.org/Development_Guidelines#Merging_to_branches
Sorry that is my bad and responsibility of assuming the triviality of it.
https://review.coreboot.org/c/flashrom/+/45944/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/45944/3//COMMIT_MSG@11 PS3, Line 11: Also renames the goto err cleanup path to make it clear.
It would have been much better to not rename the label in this patch.
What was the reasoning of not to rename it if the purpose changed in meaning?