Patch Set 3:
Why on Earth was this fast-tracked? I was sleeping when this patch was created and submitted...
https://www.flashrom.org/Development_Guidelines#Merging_to_branches
Sorry that is my bad and responsibility of assuming the triviality of it.
View Change
1 comment:
Commit Message:
Patch Set #3, Line 11: Also renames the goto err cleanup path to make it clear.
It would have been much better to not rename the label in this patch.
What was the reasoning of not to rename it if the purpose changed in meaning?
To view, visit change 45944. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Icb45b1ab39181b0f1a2dec1cce549d30db984936
Gerrit-Change-Number: 45944
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Sam McNally <sammc@google.com>
Gerrit-Reviewer: Shiyu Sun <sshiyu@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Fri, 02 Oct 2020 08:52:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment