Alan Green has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33830 )
Change subject: flashchips.c: Make end of line comments consistent ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/#/c/33830/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33830/1//COMMIT_MSG@7 PS1, Line 7: end of line comment consistency
make end of line comments consistent
Done
https://review.coreboot.org/#/c/33830/1//COMMIT_MSG@10 PS1, Line 10:
Maybe add a comma here
Done
https://review.coreboot.org/#/c/33830/1/flashchips.c File flashchips.c:
https://review.coreboot.org/#/c/33830/1/flashchips.c@2772 PS1, Line 2772: .printlock = spi_prettyprint_status_register_at45db, : .unlock = spi_disable_blockprotect_at45db, /* Impossible if locked down or #WP is low */
Just noticed these entries got switched, is it intentional? Several other places have that as well.
Intentional to do them, but they should have been in another change. Thank you for noticing.