[flashrom-gerrit] Change in ...flashrom[master]: flashchips.c: Make end of line comments consistent

[Alan Green (Code Review)]

Alan Green has posted comments on this change. (
https://review.coreboot.org/c/flashrom/+/33830 )

Change subject: flashchips.c: Make end of line comments consistent
......................................................................


Patch Set 8:

(3 comments)

https://review.coreboot.org/#/c/33830/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/33830/1//COMMIT_MSG@7 
PS1, Line 7: end of line comment consistency
  make end of line comments consistent
Done


https://review.coreboot.org/#/c/33830/1//COMMIT_MSG@10 
PS1, Line 10:  
  Maybe add a comma here
Done


https://review.coreboot.org/#/c/33830/1/flashchips.c 
File flashchips.c:

https://review.coreboot.org/#/c/33830/1/flashchips.c@2772 
PS1, Line 2772: .printlock	= spi_prettyprint_status_register_at45db,
              : 		.unlock		= spi_disable_blockprotect_at45db, /* Impossible if locked down
or #WP is low */
  Just noticed these entries got switched, is it
intentional? Several other places have that as well.
Intentional to do them, but
they should have been in another change. Thank you for noticing.



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/33830
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic4f97454766eff640b26a6c6eca29dc56c34c444
Gerrit-Change-Number: 33830
Gerrit-PatchSet: 8
Gerrit-Owner: Alan Green <avg(a)google.com>
Gerrit-Reviewer: Alan Green <avg(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Tue, 02 Jul 2019 04:22:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment