Attention is currently required from: Nico Huber, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61276 )
Change subject: hwaccess_x86_io: clean header concept ......................................................................
Patch Set 7:
(3 comments)
File hwaccess_x86_io.c:
https://review.coreboot.org/c/flashrom/+/61276/comment/0816e721_84276e82 PS6, Line 51: #define X86_IO_USE_LIBC 1
To be honest, I don't feel good about the indentation. Is there a […]
Done
https://review.coreboot.org/c/flashrom/+/61276/comment/9d8bada2_26474fe8 PS6, Line 110: #define X86_IO_USE_DOS 1
We could also set aliases for the functions, like for iopl() above, e.g. […]
This might be a problem with the correct function signature. Maybe there is a trick I don't know
https://review.coreboot.org/c/flashrom/+/61276/comment/84c73653_48b57e9e PS6, Line 259: }
The input functions could be shared with USE_SWAPPED. Maybe for another […]
Yes, an extra commit would work better.