Attention is currently required from: Nico Huber, Angel Pons.
View Change
3 comments:
File hwaccess_x86_io.c:
Patch Set #6, Line 51: #define X86_IO_USE_LIBC 1
To be honest, I don't feel good about the indentation. Is there a […]
Done
Patch Set #6, Line 110: #define X86_IO_USE_DOS 1
We could also set aliases for the functions, like for iopl() above, e.g. […]
This might be a problem with the correct function signature. Maybe there is a trick I don't know
Patch Set #6, Line 259: }
The input functions could be shared with USE_SWAPPED. Maybe for another […]
Yes, an extra commit would work better.
To view, visit change 61276. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1400704e9ac5fed00c096796536108d5bfb875e3
Gerrit-Change-Number: 61276
Gerrit-PatchSet: 7
Gerrit-Owner: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Peter Marheine <pmarheine@chromium.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Tue, 15 Feb 2022 11:09:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment