Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Michael Niewöhner. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 )
Change subject: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops ......................................................................
Patch Set 18:
(5 comments)
File ite_ecfw.c:
https://review.coreboot.org/c/flashrom/+/55715/comment/db9bd53f_5eee1d88 PS14, Line 90: wait_for_ext_crystal
When the bit is 0, then it DOESN'T wait for external crystal. […]
Ok now it is much more clear to me. Changed.
https://review.coreboot.org/c/flashrom/+/55715/comment/053bf4e7_aad1a4cd PS14, Line 315: = (blocks_1_2 ? 0x94 : 0x85);
Replaced with bit field updates
Done
https://review.coreboot.org/c/flashrom/+/55715/comment/779944e2_b1bd9b04 PS14, Line 324: 0xaa
zero means `size of 0`, which is "disable", too but only valid when the mirror bit set. […]
Added comment to the zero case
File ite_ecfw.c:
https://review.coreboot.org/c/flashrom/+/55715/comment/f02ecb9c_8d9e56b5 PS17, Line 208: 0
0: XDATA (XRAM/registers) with address as FDAT:FBUF […]
Added just an enum. Not implementing the access.
https://review.coreboot.org/c/flashrom/+/55715/comment/8c46913a_cd02a8c4 PS17, Line 813: probe_ite_superio_support(ctx_data);
Agreed. Maybe just change the name then, which was what confused me. […]
Dropped _support suffix