Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Michael Niewöhner.

View Change

5 comments:

• File ite_ecfw.c:

  • Patch Set #14, Line 90: wait_for_ext_crystal

    > When the bit is 0, then it DOESN'T wait for external crystal. […]

    Ok now it is much more clear to me. Changed.

  • Patch Set #14, Line 315: = (blocks_1_2 ? 0x94 : 0x85);

    Replaced with bit field updates

    Done

  • Patch Set #14, Line 324: 0xaa

    zero means `size of 0`, which is "disable", too but only valid when the mirror bit set. […]

    Added comment to the zero case

• File ite_ecfw.c:

  • Patch Set #17, Line 208: 0

    0: XDATA (XRAM/registers) with address as FDAT:FBUF […]

    Added just an enum. Not implementing the access.

  • Patch Set #17, Line 813: probe_ite_superio_support(ctx_data);

    Agreed. Maybe just change the name then, which was what confused me. […]

    Dropped _support suffix

To view, visit change 55715. To unsubscribe, or for help writing mail filters, visit settings.