Attention is currently required from: Peter Marheine.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67472 )
Change subject: flashrom_tester: Fix cargo check and clippy warnings ......................................................................
Patch Set 3:
(3 comments)
File util/flashrom_tester/flashrom/src/cmd.rs:
https://review.coreboot.org/c/flashrom/+/67472/comment/c1871a61_b9ed0f54 PS2, Line 89: return
This can be converted to drop the `return` too?
I suppose the linter was tricked by the {}, I updated clippy and it is now detected.
File util/flashrom_tester/src/tests.rs:
https://review.coreboot.org/c/flashrom/+/67472/comment/6859bd42_54c4615e PS2, Line 135: let mut filter_names: Option<HashSet<String>> = if let Some(names) = test_names {
I think this version is easier to understand, but if you prefer the newer version then go ahead.
obey the machine
https://review.coreboot.org/c/flashrom/+/67472/comment/15562a86_367a5f59 PS2, Line 142: .unwrap_or_else(|_| "<Unknown chip>".into());
I don't like this clippy lint; we really don't care about the cost of this allocation, and this is h […]
I added an allow() to this function, we can also put this in a package wide config if you think that is cleverer.