Attention is currently required from: Peter Marheine.

View Change

3 comments:

• File util/flashrom_tester/flashrom/src/cmd.rs:

  • Patch Set #2, Line 89: return

    This can be converted to drop the `return` too?

    I suppose the linter was tricked by the {}, I updated clippy and it is now detected.

• File util/flashrom_tester/src/tests.rs:

  • Patch Set #2, Line 135: let mut filter_names: Option<HashSet<String>> = if let Some(names) = test_names {

    I think this version is easier to understand, but if you prefer the newer version then go ahead.

    obey the machine

  • Patch Set #2, Line 142: .unwrap_or_else(|_| "<Unknown chip>".into());

    I don't like this clippy lint; we really don't care about the cost of this allocation, and this is h […]

    I added an allow() to this function, we can also put this in a package wide config if you think that is cleverer.

To view, visit change 67472. To unsubscribe, or for help writing mail filters, visit settings.