Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63488 )
Change subject: ich_descriptors_tool: Fix -Wsign-compare warnings ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/63488/comment/47b6d8a2_32bfe1e7 PS1, Line 10: and makefile.
Please explain which warnings are fixed.
I think it is done, but tell me if I misunderstood you.
File util/ich_descriptors_tool/ich_descriptors_tool.c:
https://review.coreboot.org/c/flashrom/+/63488/comment/a159e0ab_a7b96541 PS1, Line 87: uint32_t
NB. Using write(2) like this is not correct because it can be interrupted […]
I tried to combine all suggestions together. So ret is now `const ssize_t`.
One thing I haven't done: variable declarations at the beginning of the method, because it can't go together with const.
A question of using write(3) instead of write(2) looks like a good candidate to be a first ticket! I will create it when I can :)
https://review.coreboot.org/c/flashrom/+/63488/comment/e7434ff1_c904c15f PS1, Line 270: uint32_t
There's no need to use a fixed-width type here. Please use `size_t` instead.
Done thank you! I think I treated warning in a very literal way.