Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Angel Pons.

View Change

3 comments:

• Commit Message:

  • Patch Set #1, Line 10: and makefile.

    Please explain which warnings are fixed.

    I think it is done, but tell me if I misunderstood you.

• File util/ich_descriptors_tool/ich_descriptors_tool.c:

  • Patch Set #1, Line 87: uint32_t

    NB. Using write(2) like this is not correct because it can be interrupted […]

    I tried to combine all suggestions together. So ret is now `const ssize_t`.

    One thing I haven't done: variable declarations at the beginning of the method, because it can't go together with const.

    A question of using write(3) instead of write(2) looks like a good candidate to be a first ticket! I will create it when I can :)

  • Patch Set #1, Line 270: uint32_t

    There's no need to use a fixed-width type here. Please use `size_t` instead.

    Done thank you! I think I treated warning in a very literal way.

To view, visit change 63488. To unsubscribe, or for help writing mail filters, visit settings.