[flashrom-gerrit] [XS] Change in flashrom[main]: flashrom: Don't throw around "delay 1 second" so lightly

[Peter Marheine (Code Review)]

Attention is currently required from: Anastasia Klimchuk, Brian Norris, Nikolai Artemiev.

Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/80807?usp=email )

Change subject: flashrom: Don't throw around "delay 1 second" so lightly
......................................................................

Patch Set 3:

(1 comment)

Patchset:

PS1:
> My main concern is that there may be some chips in the flashchips database which need this delay, bu […]

If nobody knows why this is necessary or how to reproduce, I think it's okay to remove.

If we're feeling particularly conservative, we could add an option (perhaps `--extra-readback-delay`, but feel free to bikeshed the name) that enables the extra delay so there's an escape hatch available if it turns out somebody has such a chip- then we can suggest using that option as a fallback in `emergency_help_message()` and ask that people report cases where they need to use it (so hopefully over time the escape hatch would become unnecessary).