Brian Nemec has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41532 )
Change subject: raiden_debug_spi.c: Add protocol based configuration to init ......................................................................
Patch Set 16:
(16 comments)
https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@140 PS3, Line 140: GOOGLE_RAIDEN_SPI_PROTOCOL_V1
Ack
.
https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@266 PS3, Line 266: int16_t max_spi_write_count; : uint16_t max_spi_read_count;
jlink_spi.c has some parallels, albit a more simplified version: […]
Ack
https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@307 PS3, Line 307:
I suggest just sticking to the style already inherent in the file. […]
Done
https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@334 PS3, Line 334:
Maybe use a tab instead of eight spaces
Done
https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@352 PS3, Line 352: ctx_data->out_ep,
This looks pretty weird. […]
Done
https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@372 PS3, Line 372:
there are spaces
Done
https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@382 PS3, Line 382:
Can use tabs here
Done
https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@394 PS3, Line 394:
Can use tabs here
Done
https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@431 PS3, Line 431:
Can use tabs here
Done
https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@495 PS3, Line 495: status == 0
`if (!status)` is canonical.
Done
https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@529 PS3, Line 529: .max_data_read = 0, : .max_data_write = 0,
See comment above near the 'struct raiden_debug_spi_data'
Ack
https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@568 PS3, Line 568:
mixing tabs / spaces
Done
https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@592 PS3, Line 592: : ctx_data->max_spi_write_count= SPI_TRANSFER_V1_MAX; : ctx_data->max_spi_read_count = SPI_TRANSFER_V1_MAX;
See comment about configure_protocol() from below: Short answer protocol 2 allows SPI transfers much […]
Ack
https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@624 PS3, Line 624:
moar spaces that should be tabs
Done
https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@777 PS3, Line 777:
use tabs
Done
https://review.coreboot.org/c/flashrom/+/41532/3/raiden_debug_spi.c@813 PS3, Line 813: configure_protoco
No. Here is a two things to consider; […]
Done