16 comments:

File raiden_debug_spi.c:
- Patch Set #3, Line 140: GOOGLE_RAIDEN_SPI_PROTOCOL_V1
  Ack
  .
- Patch Set #3, Line 266:
```
int16_t max_spi_write_count;
	uint16_t max_spi_read_count;
```
  jlink_spi.c has some parallels, albit a more simplified version: […]
  Ack
- Patch Set #3, Line 307:
  I suggest just sticking to the style already inherent in the file. […]
  Done
- Patch Set #3, Line 334:
  Maybe use a tab instead of eight spaces
  Done
- Patch Set #3, Line 352: ctx_data->out_ep,
  This looks pretty weird. […]
  Done
- Patch Set #3, Line 372:
  there are spaces
  Done
- Patch Set #3, Line 382:
  Can use tabs here
  Done
- Patch Set #3, Line 394:
  Can use tabs here
  Done
- Patch Set #3, Line 431:
  Can use tabs here
  Done
- Patch Set #3, Line 495: status == 0
  `if (!status)` is canonical.
  Done
- Patch Set #3, Line 529:
```
.max_data_read  = 0,
	.max_data_write = 0,
```
  See comment above near the 'struct raiden_debug_spi_data'
  Ack
- Patch Set #3, Line 568:
  mixing tabs / spaces
  Done
- Patch Set #3, Line 592:
```
			ctx_data->max_spi_write_count= SPI_TRANSFER_V1_MAX;
			ctx_data->max_spi_read_count = SPI_TRANSFER_V1_MAX;
```
  See comment about configure_protocol() from below: Short answer protocol 2 allows SPI transfers much […]
  Ack
- Patch Set #3, Line 624:
  moar spaces that should be tabs
  Done
- Patch Set #3, Line 777:
  use tabs
  Done
- Patch Set #3, Line 813: configure_protoco
  No. Here is a two things to consider; […]
  Done

To view, visit change 41532. To unsubscribe, or for help writing mail filters, visit settings.