Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46439 )
Change subject: it87spi.c: return error when probe fails
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/c/flashrom/+/46439/1/it87spi.c
File it87spi.c:
https://review.coreboot.org/c/flashrom/+/46439/1/it87spi.c@164
PS1, Line 164: return 1;
Why exactly is this branch considered to be an error? This most likely breaks DualBIOS support.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/46439
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie122c4f954d14c713fb719ec44200b2def00fed6
Gerrit-Change-Number: 46439
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 15 Oct 2020 09:56:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment