Edward O'Callaghan has posted comments on this change. (
https://review.coreboot.org/c/flashrom/+/46439 )
Change subject: it87spi.c: return error when probe fails
......................................................................
Patch Set 1: Code-Review-2
(1 comment)
https://review.coreboot.org/c/flashrom/+/46439/1/it87spi.c
File it87spi.c:
https://review.coreboot.org/c/flashrom/+/46439/1/it87spi.c@164
PS1, Line 164: return 1;
Why exactly is this branch considered to be an error?
This most likely breaks DualBIOS support.
Thank you for the review Angel.
Nikolai, thanks for raising this with me. Angel and you are correct, this is a specific
hack on cros side that needs unwinding. The downstream commit is
5e79c9f6954127319376a8b166e501ccfb1331cd .
Nikolai, just open a bug and assign me it as this overlaps patches I have on cros side
that overlaps with this while ripping out the ec alias mechanism into a separate path. I
believe we can abandon this patch not to wast upstreams limited time and we can deal with
it in the bug.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/46439
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie122c4f954d14c713fb719ec44200b2def00fed6
Gerrit-Change-Number: 46439
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 21 Oct 2020 05:07:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment