Alan Green has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34488 )
Change subject: flashchips: Split MT25Q from N25Q ......................................................................
Patch Set 1:
Patch Set 1: -Code-Review
Sorry, run into the sorting trap. We try to enforce a sort order on .vendor, .name in `flashchips.c`, currently. I sup- pose "Micron" comes before "Micron/Numonyx/ST".
Alan, how about adding a simple check for this to the Make- file, that could be checked by Jenkins.
Ugh, I'm kind of surprised at how hard it is to get ordering "right". I didn't mean to create a burden for other devs.
How about I update my tool to deal with chips in any order and then I can put flashchips.c into the order that we want it to be - which I guess is the order that it was in.
In the meantime, happy for this these chips to go whereever you think makes the most sense.