Patch Set 1: -Code-Review

Sorry, run into the sorting trap. We try to enforce a sort
order on .vendor, .name in `flashchips.c`, currently. I sup-
pose "Micron" comes before "Micron/Numonyx/ST".

Alan, how about adding a simple check for this to the Make-
file, that could be checked by Jenkins.

Ugh, I'm kind of surprised at how hard it is to get ordering "right". I didn't mean to create a burden for other devs.

How about I update my tool to deal with chips in any order and then I can put flashchips.c into the order that we want it to be - which I guess is the order that it was in.

In the meantime, happy for this these chips to go whereever you think makes the most sense.

View Change

To view, visit change 34488. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9d79978544b19cf9acd5f3ea6196cf6f3b3435ef
Gerrit-Change-Number: 34488
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Creedon <jcreedon@google.com>
Gerrit-Reviewer: Alan Green <avg@google.com>
Gerrit-Reviewer: Jacob Creedon <jcreedon@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Mon, 05 Aug 2019 05:17:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment