Attention is currently required from: Nico Huber, Angel Pons. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52883 )
Change subject: flashchips.c: merge GD25B128B/GD25Q128B and GD25Q127C/GD25Q128C ......................................................................
Patch Set 2:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/52883/comment/0aba68fd_8c514574 PS2, Line 6274: GD25B128B
The 25B versions don't support QPI (only regular Quad-SPI wich uses a […]
Thank you for pointing that out! I had mixed up Quad SPI and QPI.
Knowing that the chips are actually different, I don't think that merging them is a good option, it would really just push the problem aside for a bit and create more work later on.
Enhancing the probing logic so that it can choose between multiple matching chips or adding a ignore list parameter seem like more robust solutions.