Attention is currently required from: Nico Huber, Angel Pons.
View Change
1 comment:
File flashchips.c:
Patch Set #2, Line 6274: GD25B128B
The 25B versions don't support QPI (only regular Quad-SPI wich uses a […]
Thank you for pointing that out! I had mixed up Quad SPI and QPI.
Knowing that the chips are actually different, I don't think that merging them is a good option, it would really just push the problem aside for a bit and create more work later on.
Enhancing the probing logic so that it can choose between multiple matching chips or adding a ignore list parameter seem like more robust solutions.
To view, visit change 52883. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I688f2e15aef61afbec728a9a81094bee56d6fbfa
Gerrit-Change-Number: 52883
Gerrit-PatchSet: 2
Gerrit-Owner: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Mon, 17 May 2021 05:36:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment