Attention is currently required from: Wonkyu Kim, Anastasia Klimchuk. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62783 )
Change subject: ichspi: Add support for Meteor Lake ......................................................................
Patch Set 1:
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62783/comment/663d6a78_99499377 PS1, Line 12: TEST=
Could you also validate the chip detection logic just as we did in https://review.coreboot. […]
Ack
https://review.coreboot.org/c/flashrom/+/62783/comment/59119531_69249d21 PS1, Line 18: rom : the chipset name.
line wrap.
Ack
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/62783/comment/2fa3c9ce_731edd78 PS1, Line 118: ",
missing from here too.
Ack
https://review.coreboot.org/c/flashrom/+/62783/comment/5cd4f213_bcf84b7f PS1, Line 1048: if (content->CSSL == 0x03) { : if (content->CSSO == 0x70) : return CHIPSET_METEOR_LAKE;
Can you elaborate on this part in the commit message to justify this will not regress Elkhart Lake d […]
Ack
File util/ich_descriptors_tool/ich_descriptors_tool.c:
https://review.coreboot.org/c/flashrom/+/62783/comment/496cce27_4ced15ff PS1, Line 130: "\t- "gemini" for Intel's Gemini Lake SoC.\n"
missing line here
Ack